This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: review of graphite testsuite patch
On Thu, 2008-08-21 at 14:06 -0500, Sebastian Pop wrote:
> On Wed, Aug 20, 2008 at 4:40 PM, Janis Johnson <janis187@us.ibm.com> wrote:
> > This review of the testsuite changes for graphite is based on
> Attached is a patch that fixes the testsuite according to these
> comments. Committed to graphite-branch.
That looks good, merge the tests to mainline when appropriate.
> > Almost all tests use the same options. Within the graphite.exp files
> > in the test suites you could set GRAPHITE_FLAGS to the options that are
> > used for most tests and pass that, instead of DEFAULT_CFLAGS, to
> > dg-runtest. Those could be overridden in individual tests. Again,
> > this is just a suggestion.
>
> This is not yet fixed.
As I said, it's just a suggestion, they're fine as they are.
> > Test gfortran.dg/graphite/scop-1.f doesn't do any checking, what is
> > its purpose?
> >
> scop-1.f was a bug that we reduced. We test it for compilation only,
> but we can also write a test for the number of SCoPs it contains.
If you don't add the test to check the dump file, add a comment
explaining that the test caused a compilation failure during
development.
Janis