This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch-rfc] N2179: Exception Propagation in C++

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Sebastian Redl <sebastian dot redl at getdesigned dot at>
Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Thu, 21 Aug 2008 14:56:09 +0200
Subject: Re: [patch-rfc] N2179: Exception Propagation in C++
References: <48809CE2.1030500@windmuehlgasse.getdesigned.at> <27280529.1217501658903.JavaMail.oracle@acsmt305.oracle.com> <18968936.1218119581291.JavaMail.oracle@acsmt304.oracle.com> <48A1E2B1.1030505@getdesigned.at> <10084862.1218570265098.JavaMail.oracle@acsmt301.oracle.com> <48A2E4B9.5010905@getdesigned.at> <27611442.1218646939544.JavaMail.oracle@acsmt304.oracle.com> <48A315C3.7070902@getdesigned.at> <48A319CE.7040006@codesourcery.com> <14256227.1218651421569.JavaMail.oracle@acsmt304.oracle.com> <6dc9ffc80808131258w546ac6f4tb45e65fcd8f5e782@mail.gmail.com> <27198639.1218657946303.JavaMail.oracle@acsmt303.oracle.com> <22543369.1218661350246.JavaMail.oracle@acsmt301.oracle.com> <48A3584D.9020402@getdesigned.at> <4083338.1218666483388.JavaMail.oracle@acsmt301.oracle.com> <48AD6385.8050303@getdesigned.at>

Sebastian Redl wrote:

I'm sorry to be so late, but I only just now noticed that you changed eh_throw.cc (__cxa_throw) to initialize the reference count to 0 instead of 1. This is incorrect.

I think it's correct, because at the same time I'm using __exchange_and_add_dispatch, which essentially is a __sync_fetch_and_add (*not* a |__sync_add_and_fetch as in your initial patch)|. I also run your testcases through valgrind.

Please double check again and in case send over a patch.

Paolo.

Follow-Ups:
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Sebastian Redl

References:
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Sebastian Redl
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Sebastian Redl
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Sebastian Redl
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Mark Mitchell
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: H.J. Lu
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Sebastian Redl
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Paolo Carlini
- Re: [patch-rfc] N2179: Exception Propagation in C++
  - From: Sebastian Redl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]