This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,libgomp,testsuite] make libgomp installed-tree testing work
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Nathan Froyd <froydnj at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, jakub at redhat dot com
- Date: Wed, 20 Aug 2008 14:54:20 -0700
- Subject: Re: [PATCH,libgomp,testsuite] make libgomp installed-tree testing work
- References: <20080812133525.GX9063@codesourcery.com>
- Reply-to: janis187 at us dot ibm dot com
On Tue, 2008-08-12 at 06:35 -0700, Nathan Froyd wrote:
> [CC'ing to Jakub for libgomp and Janis for testsuite expertise]
>
> libgomp currently relies on grovelling around in the build tree to
> determine which bits of the testsuite to execute. This doesn't work so
> well for installed-tree testing where the build tree doesn't exist.
>
> Accordingly, this patch makes installed-tree testing work properly. It
> does require the tester to set *_UNDER_TEST variables correctly in
> site.exp or similar; I wasn't sure what the best approach here was.
>
> Tested on x86_64-unknown-linux-gnu with in-tree and out-of-tree testing
> for C, C++, and Fortran with identical results. OK to commit?
I'm not familiar with running the testsuite on an installed compiler
(something that's been on my list to learn), but this looks reasonable.
OK.
Janis