This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: make real.h constants more consistent


"Manuel LÃpez-IbÃÃez" <lopezibanez@gmail.com> writes:

> 2008-08-17  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
>
> 	* real.h (dconst_e, dconst_third, dconst_sqrt2, dconst_e_ptr,
> 	dconst_third_ptr, dconst_sqrt2_ptr): Declare.
> 	(enum real_value_const): Delete.
> 	(get_real_const): Delete.
> 	* real.c (get_real_const): Delete.
> 	(dconst_e_ptr): Define.
> 	(dconst_third_ptr): Define.
> 	(dconst_sqrt2_ptr): Define.
> 	* builtins.c: Update all callers.

> +	    = real_value_truncate (TYPE_MODE (type), dconst_sqrt2());

Space before right parenthesis.  In fact, the space needs to be added
to every line you added to builtins.c.


> +#define dconst_e()  (*dconst_e_ptr())
> +#define dconst_third()  (*dconst_third_ptr())
> +#define dconst_sqrt2()  (*dconst_sqrt2_ptr())

Spaces needed here too in the macro expansion.

OK with those changes.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]