This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR36705: Procedure pointers with attributes statements
- From: "Janus Weil" <jaydub66 at googlemail dot com>
- To: "Tobias Burnus" <burnus at net-b dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 14 Aug 2008 21:55:32 +0200
- Subject: Re: [Patch, Fortran] PR36705: Procedure pointers with attributes statements
- References: <854832d40808141118k564418eah9ad6047017906ecc@mail.gmail.com> <48A48118.5080505@net-b.de>
2008/8/14 Tobias Burnus <burnus@net-b.de>:
> Is it only me who finds the preposion "in" strange in:
>
> + gfc_error ("PROCEDURE attribute conflicts with SAVE attribute "
> + "in '%s' at %L", sym->name, &sym->declared_at);
> + return FAILURE;
Well, I really just copied the error message from check_conflict, to
minimize modifications in the testsuite. If I were to choose an error
message, I'd probably pick something like
Procedure %s at %L may not have SAVE attribute.
I think talking of PROCEDURE as an attribute is misleading, especially
when the symbol is actually declared as a FUNCTION or SUBROUTINE. If
you also prefer the above (or something similar) over the old message,
I could change it in my patch before committing. Though I would not
want to change the message in check_conflict for now.
Cheers,
Janus