Re: PATCH: Fix x86 Darwin

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Thu, Jul 31, 2008 at 3:33 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Jul 31, 2008 at 3:29 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>> On Thu, Jul 31, 2008 at 3:19 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Thu, Jul 31, 2008 at 3:11 PM, Ian Lance Taylor <iant@google.com> wrote:
>>>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>>>
>>>>> 2008-07-31  H.J. Lu  <hongjiu.lu@intel.com>
>>>>>
>>>>>       * config/i386/darwin.h (ABI_STACK_BOUNDARY): Define to 128.
>>>>>       (MAIN_STACK_BOUNDARY): Likewise.
>>>>
>>>> This patch is OK if it fixes the problem.
>>>>
>>>> Thanks.
>>>
>>> Andrew,  Andreas , can you verify it?
>>
>> Except didn't we go through this before this is not the correct fix?
>>
>> See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34621
>>
>
> I am not sure what you are getting at.
>
>  ABI_STACK_BOUNDARY defines the stack boundary specified by ABI
> and MAIN_STACK_BOUNDARY defines the stack boundary at main.
> Both of them are 128bit on Darwin. Did I miss something?
>

After the second look, apparently, 4byte stack boundary is allowed by
i686 Darwin.  -mstackrealign will change incoming stack boundary to
4 byte. Please try this patch instead.


-- 
H.J.
----
2008-07-31  H.J. Lu  <hongjiu.lu@intel.com>

	* config/i386/darwin.h (MAIN_STACK_BOUNDARY): Define to 128.

Attachment: gcc-darwin-2.patch
Description: Binary data