This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix x86 Darwin


On Thu, Jul 31, 2008 at 3:29 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Thu, Jul 31, 2008 at 3:19 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Jul 31, 2008 at 3:11 PM, Ian Lance Taylor <iant@google.com> wrote:
>>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>>
>>>> 2008-07-31  H.J. Lu  <hongjiu.lu@intel.com>
>>>>
>>>>       * config/i386/darwin.h (ABI_STACK_BOUNDARY): Define to 128.
>>>>       (MAIN_STACK_BOUNDARY): Likewise.
>>>
>>> This patch is OK if it fixes the problem.
>>>
>>> Thanks.
>>
>> Andrew,  Andreas , can you verify it?
>
> Except didn't we go through this before this is not the correct fix?
>
> See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34621
>

I am not sure what you are getting at.

 ABI_STACK_BOUNDARY defines the stack boundary specified by ABI
and MAIN_STACK_BOUNDARY defines the stack boundary at main.
Both of them are 128bit on Darwin. Did I miss something?


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]