This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto][patch] Merge variable alignments and fix failure to load bodies of static functions

On Thu, Jul 31, 2008 at 1:14 PM, Diego Novillo <dnovillo@google.com> wrote:

> OK with
>
>>    if (!TREE_PUBLIC (decl))
>> -    /* Need to ensure static entities between different files
>> -       don't clash unexpectedly.  */
>> -    lang_hooks.set_decl_assembler_name (decl);
>> +    {
>> +      tree old_assembler_name = decl->decl_with_vis.assembler_name;
>
> So, here we don't use DECL_ASSEMBLER_NAME because it may set a
> new one, right?

Yes.

 Could you add a comment about it?

Sure.

Any other problems?  Or can I commit with that change?

--Bill
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]