This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: trunk: PATCH: passes with name starting with dot have no dump file.


Dave Korn wrote:
Basile STARYNKEVITCH wrote on 31 July 2008 10:56:

2008-07-31  Basile Starynkevitch  <basile@starynkevitch>
         * tree-pass.h: Added comment about not dumping passes with name
         starting with dot in struct opt_pass.

         * passes.c (register_dump_files_1): Don't do dump for a pass with
         name starting with dot.

I'm not a maintainter, so this is just IMHO: please don't invent a new convention when we already have a perfectly good one (starred names) that everyone is already familiar with from the md files.

  I understand the analogy you mentioned on the main list about Unix dir
names, but there are absolutely no ways at all in which a compiler pass is
analagous to a directory (container object in a filing system), so there is
no logic to the analogy.

  GCC is not the same thing as Unix, so we should use GCC conventions, not
Unix ones.  That's fine if the GCC convention were based on the Unix one,
but it's not, so let's not create a new one that is but is otherwise the
same.  That would be multiplying entities beyond necessity.

  Sorry for being pedantic, but I always have a maintenance programmer's
view on these kinds of things...


Good point. Should I submit a new trivial patch, or is nobody interested in having some way to avoid dump on some passes?

My motivation is still to be able to have every pass being uniquely named.

Regards.
--
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]