This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] prevent warnings from -shared-libgcc on mips-irix


Richard Sandiford wrote:
...
> Yeah, looks good, thanks.

 Thanks :)

> >   # .hidden needs to be supported in both the assembler and the linker,
> >   # because GNU LD versions before 2.12.1 have buggy support for STV_HIDDEN.
> > + # In particular, we might hide symbols in static archives to prevent
> > + # accidental resolution to them when a shared version ought to be chosen
> > + # instead, and we rely on the linker still resolving from the static
> > + # versions otherwise for such archives to remain functional alone.
> > +

> Looks OK to me, but it needs approval from a build-system maintainer.

 Sure. I'll commit the first part and will see for this other bit. Maybe
 resubmit independently.

 Thanks again for your feedback,

 Cheers,

 Olivier



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]