This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [trunk][patch] Call assemble_external for external functions.

Hi Rafael,

Rafael Espindola wrote: 
It should be called gcc.dg/visibility-14.c or similar and should use
dg-require-visibility and scan-hidden like the other visibility-* tests.

Nice!

The attached patch does just that. I believe this also fixes the hppa
problems. I have tested by adding a dummy output on assembly_external
and checking that I get the same results as before my first patch.

The patch also adds the testcase. It has bootstrap on linux x86-64. I
am bootstrapping it again on a newer trunk. OK if the tests are OK?

gcc/
2008-07-28  Rafael Avila de Espindola  <espindola@google.com>

	* final.c (call_from_call_insn): New.
	(final_scan_insn): Call assemble_external on FUNCTION_DECLs.


Is this the patch you forgot to attach in the private mail?

I'll give it right now a go on pa. (HPUX 32-bit, not linux).

Thanks a lot!

Andreas

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]