This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [trunk][patch] Call assemble_external for external functions.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at google dot com>
- Date: Mon, 28 Jul 2008 10:59:24 +0000 (UTC)
- Subject: Re: [trunk][patch] Call assemble_external for external functions.
- References: <38a0d8450807280231h25a48d36s4d9e7bc06f2b6249@mail.gmail.com>
On Mon, 28 Jul 2008, Rafael Espindola wrote:
> This fixes
> ----------------------------------------------------------------
> extern void f(void) __attribute__ ((visibility ("hidden")));
> int main () {
> f();
> }
> ----------------------------------------------------------------
>
> On x86-64. We were not emitting ".hidden f" since my patch to move the
> call to assemble_external. There is some work missing to get it
> working on hppa, but I would like to get this part fixed first.
>
> Bootstraps and has no regressions. OK for trunk (after the tuples
> merge and another testing pass maybe)?
The fact that this (which was bug 20218) got broken after having been
fixed shows up that no testcase was added with the original fix. So this
re-fix for bug 20218 should definitely add a testcase for this for ELF
targets.
--
Joseph S. Myers
joseph@codesourcery.com