Re: [PATCH] Preliminary patch to fix some function specific option breakage

[Michael Meissner <gnu at the-meissners dot org>]

On Fri, Jul 25, 2008 at 01:13:13PM -0700, H.J. Lu wrote:
> On Fri, Jul 25, 2008 at 10:29 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Fri, Jul 25, 2008 at 6:57 AM, Michael Meissner <gnu@the-meissners.org> wrote:
> >> On Fri, Jul 25, 2008 at 06:04:10AM -0700, H.J. Lu wrote:
> >>> On Fri, Jul 25, 2008 at 08:27:15AM -0400, Michael Meissner wrote:
> >>> > I've been iterating with H. J. Lu about the breakage on the IA-64, which was
> >>> > due to the cold attribute turning on options that that the backend had turned
> >>> > off in OVERRIDE_OPTIONS.  This patch should fix the ia-64, and not enable
> >>> > scheduling on the x86.
> >>> >
> >>> > On the theory that there are other ports that have the same issue, this patch
> >>> > also disables cold/hot attributes on ports that define OVERRIDE_OPTIONS but not
> >>> > the new SECONDARY_OVERRIDE_OPTIONS until we can fix the ports.  At this point,
> >>> > I just wrote the patch and did some preliminary checking on it, but I'm posting
> >>> > it now to get feedback from the other port maintainers to see if it allows
> >>> > their ports to bootstrap where previously it did not.
> >>>
> >>> SECONDARY_OVERRIDE_OPTIONS is only used to modify optimization
> >>> options. Can we use OVERRIDE_OPTIMIZATION_OPTIONS instead?
> >>
> >> Or just fold the changes into OPTIMIZATION_OPTIONS and change the
> >> documentation.  That probably is a better approach than creating yet another
> >> target hook macro.
> >>
> >> However, I can see that I will need to go over all of the ports with
> >> OVERRIDE_OPTIONS and OPTIMIZATION_OPTIONS.  Sigh...
> >>
> >> HJ, could you fire off a bootstrap build on the IA-64 with the patches (or some
> >> varient) to see whether it fixes the current issues you have?
> >>
> >
> > This patch works for me.
> >
> 
> Wrong patch. This is the correct one.

I'm going to do it by moving the scheduling reset to OPTIMIZATION_OPTIONS
rather than creating a new OVERRIDE_OPTIMIZATION_OPTIONS, since
OPTIMIZATION_OPTIONS is used only in the one place.

-- 
Michael Meissner
email: gnu@the-meissners.org
http://www.the-meissners.org