This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][RFC] Add #pragma message ... to gcc/g++

From: Mark Mitchell <mark at codesourcery dot com>
To: Simon Baldwin <simonb at google dot com>
Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
Date: Fri, 25 Jul 2008 08:44:12 -0700
Subject: Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
References: <20080718141818.B122A3FE797@localhost> <b798aad50807220643x1fb38857vbabb346a19c1b8c4@mail.gmail.com> <Pine.LNX.4.64.0807221424090.30322@digraph.polyomino.org.uk> <4885F5F5.7020307@google.com> <48867BA6.1080400@codesourcery.com> <48870112.6000304@google.com> <48875BA4.2010002@codesourcery.com> <48886899.1060804@google.com> <4888BEEA.4060304@codesourcery.com> <4889AC7B.4000706@google.com>

Simon Baldwin wrote:

I've amended the patch, test, and doc so that it now uses gcc's inform() output call. New version attached below. Please take another look.

I have no objects to this patch. However, I will defer to the C front-end maintainer to review/approve/disapprove.

I did notice the trivial fact that this comment:

+ /* Test that #pragma message "..." writes to the compiler's stdout stream. */

should be revised to remove the reference to "stdout".

Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

References:
- [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Simon Baldwin
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Diego Novillo
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Joseph S. Myers
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Simon Baldwin
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Mark Mitchell
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Simon Baldwin
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Mark Mitchell
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Simon Baldwin
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Mark Mitchell
- Re: [PATCH][RFC] Add #pragma message ... to gcc/g++
  - From: Simon Baldwin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]