This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR 36918, fix sparc bootstrap on trunk.


Michael Meissner wrote:
On Thu, Jul 24, 2008 at 09:33:03PM +0200, Andreas Tobler wrote:
Hello all,

the attached patch fixes bootstrap on sparc-solaris.
Thanks to Michael Meissner for explanation.

Tested on sparc-solaris2.10, No regressions.

Ok for trunk?

I would suggest adding a comment saying why 127 was picked.

Better?


Andreas

[wolfram:head/gcc/gcc] andreast% svn diff config/sparc/sparc.h
Index: config/sparc/sparc.h
===================================================================
--- config/sparc/sparc.h	(revision 138121)
+++ config/sparc/sparc.h	(working copy)
@@ -981,9 +981,12 @@

 /* Pick a default value we can notice from override_options:
    !v9: Default is on.
-   v9: Default is off.  */
+   v9: Default is off.
+   Originally it was -1, but later on the container of options changed to
+   unsigned byte, so we decided to pick 127 as default value, which does
+   reflect an undefined default value in case of 0/1.  */

-#define DEFAULT_PCC_STRUCT_RETURN -1
+#define DEFAULT_PCC_STRUCT_RETURN 127

 /* Functions which return large structures get the address
    to place the wanted value at offset 64 from the frame.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]