This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, committed] Add ability to set the optimization options and on ix86 target options on a function specific basis


Hello, and a couple of nits:

* Michael Meissner wrote on Wed, Jul 23, 2008 at 12:37:51PM CEST:
> --- gcc/attribs.c	(revision 138074)
> +++ gcc/attribs.c	(working copy)
> @@ -33,6 +33,7 @@ along with GCC; see the file COPYING3.  
>  #include "target.h"
>  #include "langhooks.h"
>  #include "hashtab.h"
> +#include "c-common.h"

This needs adjustment of Makefile.in, iff you really need this include.

> --- gcc/targhooks.c	(revision 138074)
> +++ gcc/targhooks.c	(working copy)
> @@ -709,4 +709,38 @@ default_hard_regno_scratch_ok (unsigned 
[...]
> +
> +  /* If both caller and callee have attributes, assume that if the pointer is
> +     different, the the two functions have different target options since

s/the the/the/

> +     build_target_option_node uses a hash table for the options.  */
> +  else
> +    ret = (callee_opts == caller_opts);

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]