This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [c/c++] PR35058: -Werror= works only with some warnings

From: "Joseph S. Myers" <joseph at codesourcery dot com>
To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Gabriel Dos Reis <gdr at integrable-solutions dot net>, Mark Mitchell <mark at codesourcery dot com>
Date: Tue, 22 Jul 2008 15:19:18 +0000 (UTC)
Subject: Re: [c/c++] PR35058: -Werror= works only with some warnings
References: <6c33472e0807220734u68f29b0wf3d1b649cb54ecd3@mail.gmail.com> <Pine.LNX.4.64.0807221451100.30322@digraph.polyomino.org.uk> <6c33472e0807220816j4c4ca8cbvfb5a680732310cb@mail.gmail.com>

On Tue, 22 Jul 2008, Manuel López-Ibáñez wrote:

> To be honest, I am not sure why I did that. So I guess that should be:
> 
> if (pedantic)
> pedwarn (OPT_pedantic, "");
> else if (extra_warnings)
> warning (OPT_Wextra, "");
> 
> If you look the case below that one, you'll notice that -Wextra warns
> for p > 0 but not for 0 < p, which seems inconsistent. Should I fix
> that or it is on purpose?

I think it should be fixed in a separate patch.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [c/c++] PR35058: -Werror= works only with some warnings
  - From: Manuel López-Ibáñez
- Re: [c/c++] PR35058: -Werror= works only with some warnings
  - From: Joseph S. Myers
- Re: [c/c++] PR35058: -Werror= works only with some warnings
  - From: Manuel López-Ibáñez

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]