This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: MIPS futex patch for OpenMP
- From: Jakub Jelinek <jakub at redhat dot com>
- To: "Fu, Chao-Ying" <fu at mips dot com>
- Cc: gcc-patches at gcc dot gnu dot org, "Garbacea, Ilie" <ilie at mips dot com>, "Lau, David" <davidlau at mips dot com>
- Date: Sun, 20 Jul 2008 07:19:17 -0400
- Subject: Re: MIPS futex patch for OpenMP
- References: <94BD67F8AF3ED34FA362C662BA1F12C501007E07@MTVEXCHANGE.mips.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Jul 17, 2008 at 04:40:34PM -0700, Fu, Chao-Ying wrote:
> Hi All,
>
> Here is one patch from Ilie Garbacea to support MIPS futex for OpenMP.
> I built GCC for the target of mips-linux-gnu and tested it on one MIPS
> Linux malta board with MIPS 74k FPGA. Test results are ok.
>
> Ex:
> # runtest --tool "gcc" --src-dir "/home/fu/dev/gcc4x/gcc/gcc/testsuite" --target_board=mips-linux-gnu-malta gcc.dg/gomp/gomp.exp
>
> === gcc Summary ===
>
> # of expected passes 429
> # of expected failures 5
> /home/fu/dev/gcc4x/install-mips-linux/bin/mips-linux-gnu-gcc version 4.4.0 2008
> 0717 (experimental) [trunk revision 131984] (GCC)
>
> # runtest --tool "g++" --src-dir "/home/fu/dev/gcc4x/gcc/gcc/testsuite" --target_board=mips-linux-gnu-malta g++.dg/gomp/gomp.exp
>
> === g++ Summary ===
>
> # of expected passes 397
> # of expected failures 1
> /home/fu/dev/gcc4x/install-mips-linux/bin/mips-linux-gnu-g++ version 4.4.0 2008
> 0717 (experimental) [trunk revision 131984] (GCC)
None of these tests actually test libgomp at all, you need to run
make check-target-libgomp.
> 2008-07-17 Ilie Garbacea <ilie@mips.com>
> Chao-ying Fu <fu@mips.com>
>
> * configure.tgt: Enable futex for MIPS.
> * config/linux/mips/futex.h: New file.
Other than that the patch looks good to me, but it would be really good
to see libgomp make check testresults.
Jakub