This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Tree broken for non-boehm-gc targets (was: ping: [patch] Link libobjc_gc with libgcjgc_convenience.la)
- From: Matthias Klose <doko at cs dot tu-berlin dot de>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: pinskia at gmail dot com, tromey at redhat dot com, gcc-patches at gcc dot gnu dot org, bonzini at gnu dot org
- Date: Fri, 18 Jul 2008 18:30:13 +0200
- Subject: Re: Tree broken for non-boehm-gc targets (was: ping: [patch] Link libobjc_gc with libgcjgc_convenience.la)
- References: <95F9AE28-5982-4B7E-B872-1D8A480BBA91@gmail.com> <200807181615.m6IGFVg4001152@ignucius.se.axis.com>
Hans-Peter Nilsson writes:
> > From: Andrew Thomas Pinski <pinskia@gmail.com>
> > Date: Thu, 17 Jul 2008 10:01:16 -0700
>
> > Sent from my iPhone
>
> Send from my PC
>
> > On Jul 17, 2008, at 8:48, Tom Tromey <tromey@redhat.com> wrote:
> >
> > >>>>>> "Matthias" == Matthias Klose <doko@cs.tu-berlin.de> writes:
> > >
> > > Matthias> Original patch at [1], suggestions from [2] implemented in
> > > [3].
> > > Matthias> Matthias
> > >
> > > Matthias> [1] http://gcc.gnu.org/ml/gcc-patches/2008-05/msg01341.html
> > > Matthias> [2] http://gcc.gnu.org/ml/gcc-patches/2008-05/msg01380.html
> > > Matthias> [3] http://gcc.gnu.org/ml/gcc-patches/2008-07/msg00275.html
> > >
> > > It seems reasonable to me, but I can only approve the boehm-gc parts.
> > > Those are ok if the libobjc parts are approved.
> > The libobjc parts are ok.
>
> But they broke objc (and broke the build) for targets that don't
> use (have ports for, have any other use for) boehm-gc:
>
> make[2]: Entering directory `/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libobjc'
> Makefile:51: ../boehm-gc/threads.mk: No such file or directory
> make[2]: *** No rule to make target `../boehm-gc/threads.mk'. Stop.
>
> I'm not sure the dependency on boehm-gc is really wanted. If it
> really is, the proper way to handle it is in toplev/configure,
> such that libobjc isn't enabled if boehm-gc is in noconfigdirs
> (and I suggest objc not be enabled either, but people complain
> when I try and depend languages on buildability of their
> libraries).
it is only needed when configured with --libobjc-gc. In this case
boehm-gc has to be built.
> I'll disable objc for CRIS and MMIX if this isn't reverted or
> fixed very soon.
I'm checking in the following patch as obvious to restore the
bootstrap on these targets. I think the proper fix is then to split
out the test as suggested by Paolo.
Matthias
2008-07-18 Matthias Klose <doko@ubuntu.com>
* Makefile.in: Ignore missing ../boehm-gc/threads.mk.
Index: Makefile.in
===================================================================
--- Makefile.in (Revision 137939)
+++ Makefile.in (Arbeitskopie)
@@ -48,7 +48,7 @@
top_builddir = .
-include ../boehm-gc/threads.mk
+-include ../boehm-gc/threads.mk
libdir = $(exec_prefix)/lib
libsubdir = $(libdir)/gcc/$(target_noncanonical)/$(gcc_version)