This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix the constant mess in PRE

From: "Daniel Berlin" <dberlin at dberlin dot org>
To: "Richard Guenther" <rguenther at suse dot de>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 18 Jul 2008 09:21:06 -0400
Subject: Re: [PATCH] Fix the constant mess in PRE
References: <alpine.LNX.1.10.0807161535520.4328@zhemvz.fhfr.qr> <4aca3dc20807161227y9be3b2emc3bae5d6088bc33e@mail.gmail.com> <4aca3dc20807161355x4444a92er6f45043f0146238c@mail.gmail.com> <alpine.LNX.1.10.0807171334340.4328@zhemvz.fhfr.qr> <4aca3dc20807170445m47456455of664dbc2426aea2c@mail.gmail.com> <alpine.LNX.1.10.0807171511160.4328@zhemvz.fhfr.qr> <alpine.LNX.1.10.0807181120490.4328@zhemvz.fhfr.qr>

>
> Which is, we do not fill in the expression-set for all constants.
> The following fixes it.  But I wonder why we need expression-sets
> for constants at all ...
>

Because we don't short circuit them in all cases.
If you are going to do the below, why not just add the add_to_value
call to alloc_constant_value_id?

Follow-Ups:
- Re: [PATCH] Fix the constant mess in PRE
  - From: Daniel Berlin

References:
- [PATCH] Fix the constant mess in PRE
  - From: Richard Guenther
- Re: [PATCH] Fix the constant mess in PRE
  - From: Daniel Berlin
- Re: [PATCH] Fix the constant mess in PRE
  - From: Richard Guenther
- Re: [PATCH] Fix the constant mess in PRE
  - From: Daniel Berlin
- Re: [PATCH] Fix the constant mess in PRE
  - From: Richard Guenther
- Re: [PATCH] Fix the constant mess in PRE
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]