This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][ARM] Support arm-android-eabi

Thanks for approving.  I picked the naming convention from the rs6000
port you pointed to me earlier but I have no perference one way or
another.

-Doug

2008/7/14 Mark Mitchell <mark@codesourcery.com>:
> Doug Kwan (Ãö®¶¼w) wrote:
>
>> - LINK_SPEC, STARTFILE_SPEC and ENDFILE_SPEC use default for
>> non-Android targets defined in header earlier in the inclusion chain
>> (bpabi.h and unknown-elf.h)
>
> Great.  I think this is OK.  However, I would prefer the spelling
> BPABI_LINK_SPEC to LINK_BPBAI_SPEC, as I suggested earlier.  (And, similarly
> for the UNKNOWN_ELF specs.)  That's more like English ("the BPBABI link
> specification") and more like OO notation ("BPABI::LINK_SPEC" or
> "BPABI.LINK_SPEC").
>
> Please make that change, and check it in again...
>
> Thanks,
>
> --
> Mark Mitchell
> CodeSourcery
> mark@codesourcery.com
> (650) 331-3385 x713
>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]