This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: ABI attributes changes entry

From: Mark Mitchell <mark at codesourcery dot com>
To: Kai Tietz <ktietz70 at googlemail dot com>
Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org, kai dot tietz at onevision dot com, gerald at pfeifer dot com
Date: Mon, 14 Jul 2008 12:07:55 -0700
Subject: Re: ABI attributes changes entry
References: <20080714171209.GC2791@kam.mff.cuni.cz> <90baa01f0807141100u7c524838v496c3d7fa15c013@mail.gmail.com>

Kai Tietz wrote:

+     <li>In 64bit mode, calling convention can be specified via <code>sysv_abi</code>
+       (used by GNU/Linux and other systems) and <code>ms_abi</code> (used by MS Windows).
+       This allow easier implementation of environments combining both ABIs,
+       such as wine.</li>
   </ul>

It's ok for me. Thank you very much.

I have some nits:

* Use "64-bit", not "64bit"

* "used by GNU/Linux and other systems" is unclear since that sounds like "all systems" at that point. Put the ms_abi clause first, so that it's obvious that "sysv4_abi" is "everything but Windows".

* Please spell out "Microsoft". "MS Windows" isn't an official name, as far as I know.

* Remove the reference to wine. I think the last sentence would be better as "You can use these attributes to write applications that use both ABIs."

Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

Follow-Ups:
- Re: ABI attributes changes entry
  - From: Gerald Pfeifer

References:
- ABI attributes changes entry
  - From: Jan Hubicka
- Re: ABI attributes changes entry
  - From: Kai Tietz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]