This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Altivec context-sensitive keywords (round 2)
- From: Ben Elliston <bje at au1 dot ibm dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, dje at watson dot ibm dot com, janis187 at us dot ibm dot com
- Date: Mon, 14 Jul 2008 15:25:25 +1000
- Subject: Re: PATCH: Altivec context-sensitive keywords (round 2)
- References: <1215065112.25281.8.camel@helios> <m3zlonatm8.fsf@fleche.redhat.com>
On Sat, 2008-07-12 at 11:40 -0600, Tom Tromey wrote:
> Note that I can only approve the libcpp bits.
That's OK. I've already got rs6000 and testsuite approval from David
and Janis.
> Ben> + if (ident == C_CPP_HASHNODE (vector_keyword) || ident == C_CPP_HASHNODE (__vector_keyword))
>
> Need to wrap these long lines.
Fixed.
> The libcpp parts are fine provided this change doesn't excessively
> impact code size or performance. Ordinarily I wouldn't look at this,
> but a similar patch of mine elsewhere got critiqued on this
> basis... so I know some other maintainers are thinking about it.
Thanks for the reminder about this. I checked and there is no
perceptible difference in memory consumption when compiling
insn-attrtab.o.
Committed.
Thanks, Ben
--
Ben Elliston <bje@au.ibm.com>
Australia Development Lab, IBM