This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: GTY as attribute
- From: Tom Tromey <tromey at redhat dot com>
- To: Taras Glek <tglek at mozilla dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 09 Jul 2008 16:43:40 -0600
- Subject: Re: GTY as attribute
- References: <4875237C.308@mozilla.com>
- Reply-to: tromey at redhat dot com
>>>>> "Taras" == Taras Glek <tglek@mozilla.com> writes:
Taras> Please consider this for inclusion in GCC. I think it's conceptually
Taras> cleaner to have GTY and attribute conventions match
I agree. I don't think there is any downside, and your use is an
upside.
You need a ChangeLog entry. There is some documentation on how to do
this in the GNU Coding Standards, plus a lot of examples in gcc :)
As Andrew said, the documentation must be updated -- but I see you did
this already.
Taras> +struct GTY(())
Taras> + edge_def {
Don't insert newlines like this.
I skimmed the patch. Nearly all of it is moving the GTYs.
I didn't read the gengtype part in context, but I didn't see anything
obviously yucky.
Note that someone else will have to approve or reject this patch.
Tom