Re: PING #2: [PATCH]: Enable vector tests for x86

[Janis Johnson <janis187 at us dot ibm dot com>]

On Mon, 2008-07-07 at 16:04 -0700, H.J. Lu wrote:
> On Mon, Jul 7, 2008 at 2:57 PM, Michael Meissner <gnu@the-meissners.org> wrote:
> > On Mon, Jul 07, 2008 at 08:42:11AM -0700, H.J. Lu wrote:
> >> Hi Janis,
> >>
> >> Can you take a look at this patch:
> >>
> >> http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00847.html
> >>
> >> Thanks.
> >
> > H. J.
> >
> > You need an appropriate dg-do run to restrict the tests to just the x86
> > architectures:
> > gcc/testsuite/gcc.dg/compat/union-m128-1_x.c
> > gcc/testsuite/gcc.dg/compat/union-m128-1_y.c
> > gcc/testsuite/gcc.dg/compat/vector-2a_x.c
> > gcc/testsuite/gcc.dg/compat/vector-2a_y.c
> >
> 
> There is
> 
> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
> 
> in the *_main.c file. They will only run on x86. On Linux/ia64, I got
> 
> UNSUPPORTED: /net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/compat/union-m128-1_main.c
> UNSUPPORTED: /net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/compat/vector-1a_main.c
> UNSUPPORTED: /net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/compat/vector-2a_main.c
> 
> OK for trunk?

Don't add 'dg-do' to the directives used in the compat tests.  Instead,
add dg-skip-if as you've done, and use that to restrict the targets on
which a test will be run, as with

  /* { dg-skip-if "test SSE2 support" { ! { i?86-*-* x86_64-*-* } } } */

OK with those changes, and I'm sorry it took me to long to review this
patch.

Janis