This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] Remove check of ctype.h include in safe-ctype.h?


Joel Brobecker <brobecker@adacore.com> writes:

>> I'm not sure we should be #including <safe-ctype.h> in gcc/system.h.
>> It seems to me that we should include it in the relatively few files
>> which need it.
>
> A quick grep of all macros defined in safe-ctype.h inside the gcc
> subdirectory gives a rather long list :-(: 78 files (see [1]).
>
> If I include the rest of the tree in the search, we have to add
> 22 more files (see [2]).
>
> I don't mind making the change, but is this desired?

That is more than I expected.  Still, I don't mind if you make this
change.  The Darwin build problem does have to be fixed one way or
another.

I'd be interested in hearing other comments.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]