This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] Cleanups for tree-ssa-operands.c
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Diego Novillo <dnovillo at google dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 4 Jul 2008 10:22:02 -0400
- Subject: Re: [tuples] Cleanups for tree-ssa-operands.c
- References: <20080704141321.GH8133@devserv.devel.redhat.com>
On Fri, Jul 04, 2008 at 10:13:21AM -0400, Jakub Jelinek wrote:
> Hi!
>
> None of these 5 trees can be ever in any GIMPLE stmt arguments,
> so they definitely don't need to be handled in get_expr_operands.
> As ATM normal OpenMP code is expanded pre-SSA and thus by SSA all the
> GIMPLE_OMP_* stmts are gone and tree-parloops.c just creates them
> and immediately expands, I don't think we need to handle any
> GIMPLE_OMP_* in tree-ssa-operands.c either.
>
> Bootstrapped/regtested on x86_64-linux, ok for tuples?
Yes, but can you put a note in the switch statement in get_expr_operands
explaining why we don't handle these cases you took out?
Thank you.
Aldy