This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [tuples] fix thinkos in forwprop

From: Aldy Hernandez <aldyh at redhat dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: dnovillo at google dot com, gcc-patches at gcc dot gnu dot org
Date: Mon, 30 Jun 2008 18:12:14 -0400
Subject: Re: [tuples] fix thinkos in forwprop
References: <20080630180907.GA16802@redhat.com> <84fc9c000806301501u136758abj72298b2df6141e24@mail.gmail.com>

On Tue, Jul 01, 2008 at 12:01:13AM +0200, Richard Guenther wrote:
> On Mon, Jun 30, 2008 at 8:09 PM, Aldy Hernandez <aldyh@redhat.com> wrote:
> > This fixes a handful of regressions caused by enabling forwprop.
> >
> > Committed to branch.
> >
> >        * tree-ssa-forwprop.c: Remove obsolete comment.
> >        (get_prop_source_stmt): Wrap call to gimple_assign_lhs with a
> >        TREE_TYPE.
> >        (forward_propagate_comparison): Use build2 instead of
> >        fold_binary.
> 
> Why that?  Trees should be always canonicalized.

fold_binary was returning NULL because it couldn't do anything with a
testcase I found while boostrapping.  I guess I could check the return
value from fold_binary-- and use build2 if fold_binary returns NULL.

I'll look into it.

Follow-Ups:
- Re: [tuples] fix thinkos in forwprop
  - From: Andrew Pinski

References:
- [tuples] fix thinkos in forwprop
  - From: Aldy Hernandez
- Re: [tuples] fix thinkos in forwprop
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]