This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Get IPA PTA working again
- From: Jan Hubicka <jh at suse dot cz>
- To: Daniel Berlin <dberlin at dberlin dot org>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <jh at suse dot cz>
- Date: Fri, 27 Jun 2008 20:21:59 +0200
- Subject: Re: [PATCH]: Get IPA PTA working again
- References: <4aca3dc20806270910h62eee773gc170f9c7573d42f8@mail.gmail.com>
> This makes IPA pta stop crashing due to stmts being marked as modified.
>
>
> Jan, maybe you could explain to me why the TODO_update_ssa we have in
> the todo_finish flags doesn't make this work?
TODO_update_ssa ought to trigger updating on all function bodies. How
does it fails for you?
>
> (It would also be nice to document the difference between
> SIMPLE_IPA_PASS and IPA_PASS, since i went down the road of seeing if
> that would fix the issue).
I will add some docs into tree-pass.h. It should not make any
difference in this.
Honza
>
> --Dan
>
>
> 2008-06-27 Daniel Berlin <dberlin@dberlin.org>
>
> * tree-ssa-structalias.c (find_func_aliases): Trivial fix to get
> ipa-pta working again.
> Index: tree-ssa-structalias.c
> ===================================================================
> --- tree-ssa-structalias.c (revision 137180)
> +++ tree-ssa-structalias.c (working copy)
> @@ -3897,7 +3897,8 @@ find_func_aliases (tree origt)
> need to re-scan most statements. FIXME: Try to minimize the
> number of statements re-scanned. It's not really necessary to
> re-scan *all* statements. */
> - mark_stmt_modified (origt);
> + if (!in_ipa_mode)
> + mark_stmt_modified (origt);
> VEC_free (ce_s, heap, rhsc);
> VEC_free (ce_s, heap, lhsc);
> }