This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] assert gimplifier assumption to prevent silent wrong code

From: "Richard Guenther" <richard dot guenther at gmail dot com>
To: "Olivier Hainque" <hainque at adacore dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 26 Jun 2008 17:36:21 +0200
Subject: Re: [PATCH] assert gimplifier assumption to prevent silent wrong code
References: <20080626140926.GA15520@cardhu.act-europe.fr> <84fc9c000806260718r7da0840dsc363ee7d5b4a579f@mail.gmail.com> <20080626145653.GA862@cardhu.act-europe.fr>

On Thu, Jun 26, 2008 at 4:56 PM, Olivier Hainque <hainque@adacore.com> wrote:
>
> Richard Guenther wrote:
>> This is ok if you move the assert inside the gimplify_modify_expr_to_memset
>> function.
>
>  Sure. There's a bit of uncertainty on what to expect possibly ahead
>  of the CONSTRUCTOR tree: at least a WITH_SIZE_EXPR since this is what
>  we'd have from the current unique call context, anything else you'd
>  like to see checked ?

WITH_SIZE_EXPR shouldn't be checked - after all we could decide to
gimplify to memset also for constant-sized assignments.  I think the
empty CONSTRUCTOR is enough.

Richard.

Follow-Ups:
- Re: [PATCH] assert gimplifier assumption to prevent silent wrong code
  - From: Olivier Hainque

References:
- [PATCH] assert gimplifier assumption to prevent silent wrong code
  - From: Olivier Hainque
- Re: [PATCH] assert gimplifier assumption to prevent silent wrong code
  - From: Richard Guenther
- Re: [PATCH] assert gimplifier assumption to prevent silent wrong code
  - From: Olivier Hainque

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]