This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] PR 31754/C++ - make -fshow-column produce more accurate column numbers
>>>>> "Manuel" == Manuel LÃpez-IbÃÃez <lopezibanez@gmail.com> writes:
Dodji> diff --git a/gcc/testsuite/lib/g++.exp b/gcc/testsuite/lib/g++.exp
Dodji> - lappend options "additional_flags=-fno-show-column"
Dodji> +#don't hardcode -fno-show-column
Dodji> +#lappend options "additional_flags=-fno-show-column"
Dodji> lappend options "compiler=$GXX_UNDER_TEST"
>> Just delete this -- we generally don't comment out dead code in GCC.
Manuel> Moreover, it is strange that we had this additional flag for nothing.
Manuel> I think that if it doesn't break any test, we should remove it
Manuel> straight away.
I think this line pre-dated the change of default for -fshow-column.
So, I think at one point it did actually do something.
Tom