This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix latent bug in __expand_buitin_nonlocal_goto


> On Sun, Jun 22, 2008 at 4:46 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> > On Tue, Jun 17, 2008 at 11:58 AM, Jan Hubicka <jh@suse.cz> wrote:
> >> Hi,
> >> with SSA at O0 the following testcase in testsuite:
> >
> > This causes a failure on powerpc*-*-* as the restore_stack_nonlocal
> > pattern requires a memory address for the saved stack pointer.
> > I think the x86 back-end should change to stabilize the saved pointer
> > to a register.
> 
> Looking over the code for expand_builtin_nonlocal_goto, I think we
> should stabilize r_save_area instead of r_sp.  This will cause us to

Yes, that would work too.  I didn't know some targets actually require
MEM exrepssion here.
Could you test if it solves PPC problem?

Honza
> create a MEM of a REG instead of a MEM of a REG plus constant where
> REG will most likely be the frame pointer.
> 
> Thanks,
> Andrew Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]