This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix initialization of gomp_remaining_threads_lock
- From: Jakub Jelinek <jakub at redhat dot com>
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 15 Jun 2008 17:34:22 -0400
- Subject: Re: [PATCH] Fix initialization of gomp_remaining_threads_lock
- References: <20080615212147.F170A4E71@hiauly1.hia.nrc.ca>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Jun 15, 2008 at 05:21:47PM -0400, John David Anglin wrote:
> This patch fixes the initialization of the gomp_remaining_threads_lock
> mutex. On hppa-linux, gomp_thread_limit_var is ULONG_MAX. Thus, the
> mutex gomp_remaining_threads_lock isn't initialized with the current code.
gomp_remaining_threads_lock has been initially used just in
gomp_resolve_num_threads where it wouldn't be touched for
gomp_thread_limit_var == ULONG_MAX. But later on I've started using
it even in team.c and forgot to adjust initialize_env. Sorry.
>
> 2008--06-14 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
^ too many hyphens
>
> * env.c (initialize_env): Always initialize gomp_remaining_threads_lock
> mutex when HAVE_SYNC_BUILTINS isn't defined.
Okay.
Jakub