This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, v3] Drop trailing white space in include/Makefile.am

From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Sun, 15 Jun 2008 14:51:39 +0200
Subject: Re: [PATCH, v3] Drop trailing white space in include/Makefile.am
References: <20080615091059.GC12733@ins.uni-bonn.de> <15589290.1213531382252.JavaMail.oracle@acsmt303.oracle.com>

Hello Paolo,

Thanks for the quick reviews!

* Paolo Carlini wrote on Sun, Jun 15, 2008 at 02:03:02PM CEST:
> > OK for trunk?  bootstrapped and regtested x86_64-unknown-linux-gnu.
> 
> Yes, it's ok, thanks. As a matter of fact, if you have reasons to
> believe that the bug can cause problems also with the current 2.59 /
> 1.9.6 pair I strongly recommend committing to 4_3-branch too.

Indeed, at least the
  @if [ ! -d "${ext_builddir}" ]

test done as part of the stamp-ext rule is bogus without this patch,
so there may be a bogus error message from mkdir due to the existing
directory.  Applied to trunk and 4.3.

Cheers,
Ralf

References:
- [PATCH, v3] Drop trailing white space in include/Makefile.am
  - From: Ralf Wildenhues
- Re: [PATCH, v3] Drop trailing white space in include/Makefile.am
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]