This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR middle-end/36253: Caller-save stack slot may not have proper alignment
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Joey Ye <joey dot ye at intel dot com>, Xuepeng Guo <xuepeng dot guo at intel dot com>
- Date: Sat, 14 Jun 2008 23:58:56 -0400 (EDT)
- Subject: Re: PATCH: PR middle-end/36253: Caller-save stack slot may not have proper alignment
- References: <20080517151054.GA21092@lucon.org> <20080517202056.GA5330@lucon.org> <20080517235634.GA11667@lucon.org>
On Sat, 17 May 2008, H.J. Lu wrote:
> > Here is the updatd patch to use gcc_assert instead.
Please build at least their cc1 when you change targets like
this.
> -#define LOCAL_ALIGNMENT(TYPE, BASIC_ALIGN) \
> - mmix_local_alignment (TYPE, BASIC_ALIGN)
> +#define LOCAL_ALIGNMENT(TYPE, (MODE), BASIC_ALIGN) \
Typo.
> + mmix_local_alignment (TYPE, (MODE), BASIC_ALIGN)
Needless parenthization (sp?).
I agree with Richi to change your change into a NOP.
brgds, H-P