This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [trunk][patch] gimplify type sizes in a pointer type
- From: Diego Novillo <dnovillo at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, hainque at adacore dot com
- Date: Thu, 12 Jun 2008 07:37:48 -0400
- Subject: Re: [trunk][patch] gimplify type sizes in a pointer type
- References: <38a0d8450806120030t19cfd10bi5296ced2e26bc126@mail.gmail.com>
On 2008-06-12, Rafael Espindola <espindola@google.com> wrote:
> 2008-06-11 Rafael Espindola <espindola@google.com>
>
> * gimplify.c (gimplify_target_expr): Always gimplify the type of INIT.
> (gimplify_type_sizes): Recurse on pointer types.
This was removed by Olivier Hainque in 2006, in theory removing this
code ought to give you failures in gcc.dg/typename-vla-1.c and
gnat.dg/forward_vla.adb. I'm CCing Olivier in case he remembers other
details.
If those two tests still work, then the conditions are no longer true
and the patch is OK. We certainly don't want any non-gimple nodes in
the IL after gimplification.
Diego.