This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
PATCH: PR testsuite/36443: [4.3/4.4 Regression]: HOSTCC doesn't work with unstalled gcc
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Fri, 6 Jun 2008 19:55:15 -0700
- Subject: PATCH: PR testsuite/36443: [4.3/4.4 Regression]: HOSTCC doesn't work with unstalled gcc
Gcc 4.3 or above will honor GCC_EXEC_PREFIX. When GCC_EXEC_PREFIX is
set for "make check", several things will happen:
1. GCC_EXEC_PREFIX points to non-existent directory:
a. If system compiler is gcc 4.3, HOSTCC won't work.
b. If system compiler is gcc 4.2 or older, HOSTCC works since
they will ignore GCC_EXEC_PREFIX.
2. If GCC_EXEC_PREFIX points to the older gcc 4.4 installation,
old files may be used, instead of the current ones, which
are just built, but not installed.
I don't see a good reason to set GCC_EXEC_PREFIX for native
"make check". OK for trunk?
Thanks.
H.J.
---
2008-06-05 H.J. Lu <hongjiu.lu@intel.com>
PR testsuite/36443
* Makefile.in (site.exp): Don't set GCC_EXEC_PREFIX.
Don't set GCC_EXEC_PREFIX before calling $(RUNTEST).
Index: Makefile.in
===================================================================
--- Makefile.in (revision 2946)
+++ Makefile.in (revision 2947)
@@ -4270,7 +4270,6 @@ site.exp: ./config.status Makefile
@echo "set HOSTCFLAGS \"$(CFLAGS)\"" >> ./tmp0
@echo "set TESTING_IN_BUILD_TREE 1" >> ./tmp0
@echo "set HAVE_LIBSTDCXX_V3 1" >> ./tmp0
- @echo "set GCC_EXEC_PREFIX \"$(libdir)/gcc/\"" >> ./tmp0
# If newlib has been configured, we need to pass -B to gcc so it can find
# newlib's crt0.o if it exists. This will cause a "path prefix not used"
# message if it doesn't, but the testsuite is supposed to ignore the message -
@@ -4352,7 +4351,6 @@ $(lang_checks): check-% : site.exp
if [ -f $${rootme}/../expect/expect ] ; then \
TCL_LIBRARY=`cd .. ; cd $${srcdir}/../tcl/library ; ${PWD_COMMAND}` ; \
export TCL_LIBRARY ; fi ; \
- GCC_EXEC_PREFIX="$(libdir)/gcc/" ; export GCC_EXEC_PREFIX ; \
$(RUNTEST) --tool $* $(RUNTESTFLAGS))
check-consistency: testsuite/site.exp
@@ -4363,7 +4361,6 @@ check-consistency: testsuite/site.exp
if [ -f $${rootme}/../expect/expect ] ; then \
TCL_LIBRARY=`cd .. ; cd $${srcdir}/../tcl/library ; ${PWD_COMMAND}` ; \
export TCL_LIBRARY ; fi ; \
- GCC_EXEC_PREFIX="$(libdir)/gcc/" ; export GCC_EXEC_PREFIX ; \
$(RUNTEST) --tool consistency $(RUNTESTFLAGS)
# QMTest targets