This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 6/6 v4]: Merge from Stack Branch - Test Cases
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: "Ye, Joey" <joey dot ye at intel dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Guenther <richard dot guenther at gmail dot com>, "Lu, Hongjiu" <hongjiu dot lu at intel dot com>, "Guo, Xuepeng" <xuepeng dot guo at intel dot com>, Jan Hubicka <hubicka at ucw dot cz>, Jason Merrill <jason at redhat dot com>, Ian Lance Taylor <iant at google dot com>, Gerald Pfeifer <gerald at pfeifer dot com>, Bernd Schmidt <bernds_cb1 at t-online dot de>, Mark Mitchell <mark at codesourcery dot com>
- Date: Thu, 05 Jun 2008 15:56:12 -0700
- Subject: Re: [PATCH 6/6 v4]: Merge from Stack Branch - Test Cases
- References: <BB577BF501703042AD7E08EADD8E514FF5DDC8@pdsmsx415.ccr.corp.intel.com>
- Reply-to: janis187 at us dot ibm dot com
On Thu, 2008-06-05 at 16:03 +0800, Ye, Joey wrote:
> Updated version.
>
> 2008-06-05 H.J. Lu <hongjiu.lu@intel.com>
> Joey Ye <joey.ye@intel.com>
>
> * gcc.target/i386/20060512-1.c: Add
> -mpreferred-stack-boundary=4.
> (main): Move "popl" after check.
> * gcc.target/i386/20060512-3.c: Likewise.
[lots more]
When a test has been copied from another part of the testsuite, add a
comment giving the path of the original.
Avoid using C library functions and their headers whenever possible.
For example, instead of including <string.h> and calling strncpy, call
__builtin_strncpy.
Add comments to tests in which the purpose isn't clear, as with
gcc.target/i386/stackalign/asm-1.c
gcc.target/i386/stackalign/return-2.c
They compile with no additional checks; did they cause ICEs in earlier
versions on the branch?
Torture option handling was cleaned up recently, and it should be
possible to make gcc.dg/torture/stackalign/stackalign.exp much
simpler by combining the existing C_TORTURE_OPTIONS with your
sets of additional options.
Just FYI (I don't mind if it stays the way it is), this:
/* { dg-do run } */
/* { dg-require-effective-target ilp32 } */
/* { dg-require-effective-target dfp } */
is the same as this:
/* { dg-do run { target { ilp32 && dfp } } } */
or this:
/* { dg-do run } */
/* { dg-require-effective-target { ilp32 && dfp } } */
Unless there are other objections you can add these tests when the
functionality has been committed.
Janis