This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto-streamer][patch] produce distinct error messages for unimplemented codes


On 6/5/08 8:56 AM, Rafael Espindola wrote:
Currently we have to open a debugger to find out which TREE_CODE is
unsupported by output_tree when it fails. This patch makes the error
message for each one distinct. This also makes it easier to run delta
to find a minimal test for a particular error.

* lto-function-out.c (output_tree): Add calls to gcc_unreachable for
each unimplemented TREE_CODE.


Actually, it's better if you leave it as is and just add an error() message with the failed code before the gcc_unreachable() call. See for instance get_expr_operands() or gimplify_expr().


The ChangeLog entry is mis-formatted, it's missing the date and your address.

OK with those changes.


Diego.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]