This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, Ada] another round of typos


Hi Arnaud,

* Arnaud Charlet wrote on Sun, Jun 01, 2008 at 01:56:40PM CEST:
> > bootstrap and regtest on i686-pc-linux-gnu are running.  OK for trunk if
> > they succeed?
> > 
> > Does this patch need testing on w32, and if yes, can somebody do it
> > for me, and how come the Makefile.in typos were not found earlier?
> 
> Actually the .exe extension is optional and will be added by default, so
> that's probably why it got unnoticed, but worth fixing.

OK.

> > Is the change in vms_data.ads right?
> 
> Seems right, but the following change is wrong, since overriding has a
> different meaning from overridden.

OK, sorry about that; but then, the duplicate d is still wrong.

> > --- a/gcc/ada/sem_ch6.adb
> > +++ b/gcc/ada/sem_ch6.adb
> > @@ -3555,7 +3555,7 @@ package body Sem_Ch6 is
> >                       if not Is_Overriding_Operation (Op) then
> >                          Error_Msg_N ("\\primitive % defined #", Typ);
> >                       else
> > -                        Error_Msg_N ("\\overridding operation % with " &
> > +                        Error_Msg_N ("\\overridden operation % with " &
> >                                       "convention % defined #", Typ);
> >                       end if;
> >  
> 
> Patch is OK without the hunk above, thanks.

OK with this instead?

-                        Error_Msg_N ("\\overridding operation % with " &
+                        Error_Msg_N ("\\overriding operation % with " &

Thanks for the speedy review.

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]