This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix call-clobbering (PRs 36373 and 36387)
- From: "Daniel Berlin" <dberlin at dberlin dot org>
- To: "Richard Guenther" <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, "Diego Novillo" <dnovillo at google dot com>
- Date: Fri, 30 May 2008 21:05:23 -0400
- Subject: Re: [PATCH] Fix call-clobbering (PRs 36373 and 36387)
- References: <Pine.LNX.4.64.0805310004080.26762@zhemvz.fhfr.qr>
On Fri, May 30, 2008 at 6:12 PM, Richard Guenther <rguenther@suse.de> wrote:
>
> The current call-clobbering code as far as it deals with using
> the PTA results is missing quite a few cases. First escaped
> aggregates (as opposed to pointers) are not tracked at all.
Only because you removed the code to do so when you removed SFT's :)
> Second, we miss to compute the reachability set of the
> escaped pointers and only clobber the directly pointed-to
> memory.
This is because we relied on pta results getting transformed into
NMT's, and then the NMT's were walked during transitive closure.
What broke this, it should have worked fine, because the loop in
mark_call_clobbered already does a transitive closure.