This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] Robustify cleanup_omp_return
- From: Diego Novillo <dnovillo at google dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Aldy Hernandez <aldyh at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 30 May 2008 10:32:57 -0400
- Subject: Re: [tuples] Robustify cleanup_omp_return
- References: <20080530142630.GC16061@devserv.devel.redhat.com>
On Fri, May 30, 2008 at 10:26, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> This function is called during cfg cleanup, so bb might be preceeded
> by an empty useless block. Given the cfg creation for
> GIMPLE_OMP_SECTIONS_SWITCH, I'm convinced the final sections
> GIMPLE_OMP_RETURN will be always preceeded by GIMPLE_OMP_SECTIONS_SWITCH,
> so there is no need to search through empty bbs to find
> GIMPLE_OMP_SECTIONS_SWITCH.
Hmm, Aldy had a similar patch yesterday and I asked him to verify that
he wasn't papering over anything. It looked strange to me that we
need this in tuples but not in trunk. Maybe we do, but I'd like to
understand why.
Aldy, did you find out anything new about this?
Thanks. Diego.