This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] Fix handling of OpenMP shared variables
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 28 May 2008 18:37:30 -0400
- Subject: Re: [tuples] Fix handling of OpenMP shared variables
- References: <20080528211426.GU16061@devserv.devel.redhat.com>
On Wed, May 28, 2008 at 05:14:26PM -0400, Jakub Jelinek wrote:
> Hi!
>
> lower_omp_1 needs to regimplify anything containing VAR_DECLs with
> DECL_VALUE_EXPR (primarily shared vars being replaced with
> .omp_data->var). gimple_regimplify_operands doesn't help, because
> the gimple operands already satisfy their predicates. The following
> patch fixes it by calling gimple_expr unconditionally on the operands
> if we found some VAR_DECL with DECL_HAS_VALUE_EXPR_P among the operands.
Woah, I see tons of new ICE's with this patch. Did you test gomp.exp?
e.g, this, among others fails:
gcc.dg/gomp/pr34610.c
We used to have about 6 failures in gomp.exp. We now have 40.
Aldy