This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] profile feedback: -fprofile-use= and -fprofile-correction, correctness fixes and option semantic changes.
- From: "Seongbae Park (박성배, 朴成培)" <seongbae dot park at gmail dot com>
- To: "Jan Hubicka" <jh at suse dot cz>
- Cc: "Jan Hubicka" <hubicka at ucw dot cz>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 28 May 2008 15:04:00 -0700
- Subject: Re: [PATCH] profile feedback: -fprofile-use= and -fprofile-correction, correctness fixes and option semantic changes.
- References: <ab3a61990803201358l2da959c0t166e9bdfba53dd09@mail.gmail.com> <20080330131315.GB28471@atrey.karlin.mff.cuni.cz> <ab3a61990803301353n7f6d6a86u194bc39a78b32215@mail.gmail.com> <ab3a61990804021517v1f50537bj7ef7a27db9108d0b@mail.gmail.com> <20080403063951.GE16935@kam.mff.cuni.cz> <ab3a61990804030958h2e6b35d8oca0aa854c9a833b9@mail.gmail.com> <ab3a61990804031630xf235ee6me363b2ca008d13d3@mail.gmail.com> <ab3a61990805271356s2246a5c1nb31104cc6ab8a796@mail.gmail.com> <20080528125714.GE16497@kam.mff.cuni.cz> <ab3a61990805281115s26da6d4evc5982fb45cf869b7@mail.gmail.com>
On Wed, May 28, 2008 at 11:15 AM, Seongbae Park (박성배, 朴成培)
<seongbae.park@gmail.com> wrote:
> On Wed, May 28, 2008 at 5:57 AM, Jan Hubicka <jh@suse.cz> wrote:
>>>
>>> ping^3 (or ^4 counting ping on irc :)) for the above patch and:
>>>
>>> http://gcc.gnu.org/ml/gcc-patches/2008-04/msg00112.html
>>
>> This is OK^4. Thanks for the patience and reminding me!
>>
>> Honza
>>>
>>> Seongbae
>
> Now that I got the approval, synced to the latest, and ran the test again,
> I noticed that the patch as is was causing an extra FAIL
> due to the additional source file in this patch not being ignored.
>
> I've worked around it by a hack. I think the change is obvious
> (although somewhat hideous)
> since it doesn't change the real testcase nor the actual fix.
> So I've committed this as revision 136118.
> The patch as applied is attached.
>
> Seongbae
>
> 2008-05-28 Seongbae Park <seongbae.park@gmail.com>
>
> * value-prof.c (tree_ic_transform): Print counts.
> * tree-profile.c (tree_gen_ic_func_profiler):
> Clear __gcov_indreict_call_callee variable
> to avoid misattribution of the profile.
>
> 2008-05-28 Seongbae Park <seongbae.park@gmail.com>
>
> * gcc.dg/tree-prof/ic-misattribution-1.c: New test.
> * gcc.dg/tree-prof/ic-misattribution-1a.c: New test.
> * lib/profopt.exp (profopt-get-options): Support dg-additional-sources.
> (profopt-execute): Handle additional sources.
>
This patch broke bootstrap on targets where gcov_type != long long int.
Applied the following patch as obvious (after consulting global
maintainers on irc) - svn revision 136131.
Sorry about the breakage.
Seongbae
2008-05-28 Seongbae Park <seongbae.park@gmail.com>
* value-prof.c (tree_ic_transform): Use HOST_WIDEST_INT_PRINT_DEC
for printing gcov_type.