This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Stack corruption in naked functions.

Richard Guenther wrote:

I merely wanted to raise the concern that user errors will be noticed as ICEs
and not errors, which will lead to false bug-reports.  It would be nice if we
can emit an error, even if we cannot make sure to not ICE afterwards - that
will be a confused after errors, which is way better than an ICE with an
instruction to report a bug.

How does this relate to Carlos' patch?

Carlos' patch keeps the compiler itself from copying arguments in registers to the stack for naked functions. That doesn't sound like papering over to me; it sounds like an essential fix.

How does Honza's patch relate to this at all? Even if doing some optimizations would eliminate the copies, etc., depending on the optimizers to avoid using the stack seems fragile.

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]