This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, Fortran] Parse FINAL procedure declarations



One remark:


Daniel Kraft wrote:
+/* Free a finalizer procedure list.  */
+
+static void
+gfc_free_finalizer_list (gfc_finalizer* l)
+{
+  while (l)
+    {
+      gfc_finalizer* current = l;
+      l = l->next;
+
+      --current->procedure->refs;
+      if (!current->procedure->refs)
+        gfc_free_symbol (current->procedure);
+
+      gfc_free (current);
+    }
+}
+
+

Please don't use 'l' as variable name. It looks too much like '1' in some fonts (exactly the same in my mailer). Thus I read this as infinite loop and wondered where the exit condition was.


Regards,
- Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]