This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] Adjust output for strings in tree-pretty-print.c
- From: Manfred Hollstein <mh at novell dot com>
- To: FX <fxcoudert at gmail dot com>
- Cc: GCC Development <gcc at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 19 May 2008 16:20:51 +0200
- Subject: Re: [RFC] Adjust output for strings in tree-pretty-print.c
- References: <19c433eb0805190659g7442d645ga7755ec598856463@mail.gmail.com>
- Reply-to: Manfred Hollstein <manfred at die-hollsteins dot de>
Hi there,
On Mon, 19 May 2008, 15:59:16 +0200, FX wrote:
> [...]
> Any comments? Is it OK to commit as is?
this may sound like nit-picking, but the length of a string cannot be
negative, so, I'd rather make the new parameter `len' an "unsigned int"
or even size_t.
HTH, cheers.
l8er
manfred