This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, tree-dce]: DCE enh to handle dead calls (not pure)


On Sun, 18 May 2008, Steven Bosscher wrote:

> In the past, commit rights for the GCC repository were only given to
> people who regularly submitted good patches, and who had shown with
> prior patch submissions that they understood the GCC patch process.  I
> understand that nowadays commit rights are given away much more
> easily, but you have *never* submitted a patch before, and you clearly
> don't understand the process either.  You just abused your commit
> rights. If you don't know how things work, you should just not have
> commit rights yet.

Indeed, this is documented policy:

   Write after approval.
          This is folks that make regular contributions, but do not fall
          into one of the two previous categories. People with write
          after approval need to submit their patches to the list; once
          the patches have been approved by the appropriate maintainers
          the patches may be checked into the GCC sources. The steering
          committee or a well-established GCC maintainer (including, but
          not limited to global write maintainers) can approve for write
          access any person with GNU copyright assignment papers in place
          and known to submit good patches.

Note the "make regular contributions" and "known to submit good patches".  
Approving for write access someone who is not known to submit good patches 
is contrary to this policy.

Anyone making nontrivial contributions (including anyone who gets SVN 
write access) should read contribute.html, svnwrite.html, svn.html, 
codingconventions.html and the GNU Coding Standards, as well as reading 
other patch submissions on the lists and learning from the prevailing 
style and customs.  Anyone contributing at all (even trivial 
contributions) should have read enough existing code to follow a 
reasonable approximation to the prevailing style: this is not a 
GCC-specific matter, it is a basic matter for anyone contributing to any 
existing code base at all to conform to the practices followed in that 
code base.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]