This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [trunk] patch to clean up simulation of insns in df.
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Kenneth Zadeck <zadeck at naturalbridge dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Julian Brown <julian at codesourcery dot com>
- Date: Fri, 16 May 2008 11:15:49 +0200
- Subject: Re: [trunk] patch to clean up simulation of insns in df.
- References: <482CF7A4.9030509@naturalbridge.com>
I renamed df_simulate_artificial_refs_at_end to
df_simulate_artificial_refs_at_end_backwards and renamed
df_simulate_artificial_refs_at_top to
df_simulate_artificial_refs_at_top_backwards.
The idea is obviously okay. However I'd rather avoid the _backwards
suffix since right now we only support backwards scanning. I mean, if
the suffix had been there before, I'd have removed it together with
df_simulate_one_insn_forwards. The comment you added tells that
df_simulate_artificial_refs_at_* is okay only for backwards scanning.
In practice, this would reduce the patch to these hunks only:
(df_simulate_artificial_refs_at_top):
Reversed scanning of defs and uses.
(df_simulate_one_insn_forwards): Removed.
which would have been a tad simpler to review too.
Paolo