This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] 'enabled' attribute - revised version
- From: "Andreas Krebbel" <Andreas dot Krebbel at de dot ibm dot com>
- To: Richard Sandiford <rsandifo at nildram dot co dot uk>, mark at codesourcery dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 13 May 2008 12:44:55 +0200
- Subject: Re: [PATCH] 'enabled' attribute - revised version
- References: <20080509112548.GA15673@homer.boeblingen.de.ibm.com> <87bq3ffllv.fsf@firetop.home>
Hi,
> For the record, this looks good to me, thanks.
>
> I've a mild preference for skip_alternative taking the old contraint
> position and returning the new position, rather than taking a pointer
> to the position and adjusting it in-situ. But maybe that's just me.
I did it that way due to the const char* vs. char* conflicts between
reload and recog. Without modifying the pointer in-place the code
would remove the const qualifier by either casting or parameter
passing.
> The markup of:
>
> `enabled'
>
> doesn't look right. Texinfo quotes are `` and '' (like TeX),
> but existing attribute docs seem to use @code{...} instead.
Ok. Fixed.
Mark, is that ok to apply to mainline with the documentation fix above?
Bye,
-Andreas-